Commit bed7d30d authored by wujipeng's avatar wujipeng
Browse files

查询全部课程接口

parent ed1023e7
package com.platform.business.controller; package com.platform.business.controller;
import com.baomidou.mybatisplus.core.conditions.query.LambdaQueryWrapper;
import com.platform.business.model.dto.ClassSubjectDTO; import com.platform.business.model.dto.ClassSubjectDTO;
import com.platform.business.model.entity.ClassSubjectEntity;
import com.platform.business.model.entity.SysPhoneRoleEntity;
import com.platform.business.model.entity.UserEntity;
import com.platform.business.model.vo.SysTeacherCountVO; import com.platform.business.model.vo.SysTeacherCountVO;
import com.platform.business.service.AuthenticatedUserService;
import com.platform.business.service.ClassSubjectService; import com.platform.business.service.ClassSubjectService;
import com.platform.business.service.SysPhoneRoleService;
import com.platform.business.utils.JwtTokenUtil; import com.platform.business.utils.JwtTokenUtil;
import com.platform.controller.BaseController; import com.platform.controller.BaseController;
import com.platform.exception.BusinessException;
import com.platform.model.resp.Result; import com.platform.model.resp.Result;
import io.swagger.annotations.ApiOperation; import io.swagger.annotations.ApiOperation;
import org.springframework.web.bind.annotation.*; import org.springframework.web.bind.annotation.*;
...@@ -13,6 +20,10 @@ import javax.annotation.Resource; ...@@ -13,6 +20,10 @@ import javax.annotation.Resource;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpServletResponse;
import java.io.IOException; import java.io.IOException;
import java.util.List;
import static com.platform.business.constant.AccountAdminConstants.ROLE_ADMIN;
import static com.platform.business.constant.AccountAdminConstants.ROLE_TEACHER;
@RestController @RestController
@RequestMapping("/class/subject") @RequestMapping("/class/subject")
...@@ -24,6 +35,12 @@ public class ClassSubjectController extends BaseController { ...@@ -24,6 +35,12 @@ public class ClassSubjectController extends BaseController {
@Resource @Resource
private JwtTokenUtil jwtTokenUtil; private JwtTokenUtil jwtTokenUtil;
@Resource
private AuthenticatedUserService authenticatedUserService;
@Resource
private SysPhoneRoleService sysPhoneRoleService;
@PostMapping("/saveOrUpdate") @PostMapping("/saveOrUpdate")
public Result save(@RequestBody ClassSubjectDTO classSubjectDTO) { public Result save(@RequestBody ClassSubjectDTO classSubjectDTO) {
return Result.data(classSubjectService.saveOrUpdateSubject(classSubjectDTO)); return Result.data(classSubjectService.saveOrUpdateSubject(classSubjectDTO));
...@@ -57,4 +74,40 @@ public class ClassSubjectController extends BaseController { ...@@ -57,4 +74,40 @@ public class ClassSubjectController extends BaseController {
return Result.data(classSubjectService.queryByTeacherUserName(userName)); return Result.data(classSubjectService.queryByTeacherUserName(userName));
} }
/**
* 根据当前登录用户的数据权限查询课程列表。
*
* <p>管理员可以查看全部课程;教师只能查看 {@code teacher_id} 等于本人用户 ID 的课程。
* 当前用户和角色均由服务端根据 Authorization 令牌解析,接口不接收 teacherId,避免教师
* 通过伪造参数越权查看其他教师的排课数据。</p>
*/
@ApiOperation("查询当前用户有权查看的全部课程")
@GetMapping("/list")
public Result<List<ClassSubjectEntity>> list(HttpServletRequest request) {
UserEntity currentUser = authenticatedUserService.current(request);
List<SysPhoneRoleEntity> roles = sysPhoneRoleService.queryByPhone(currentUser.getPhoneNumber());
// 管理员权限优先:兼容同一账号同时拥有管理员和教师角色的情况,此时返回全量课程。
boolean administrator = hasRole(roles, ROLE_ADMIN);
boolean teacher = hasRole(roles, ROLE_TEACHER);
if (!administrator && !teacher) {
throw new BusinessException("只有教师或管理员可以查询课程列表");
}
LambdaQueryWrapper<ClassSubjectEntity> query = new LambdaQueryWrapper<>();
if (!administrator) {
// 教师 ID 必须取自登录态,不能使用客户端参数,以保证数据范围始终限定为本人课程。
query.eq(ClassSubjectEntity::getTeacherId, currentUser.getId());
}
// 增加固定排序,避免数据库默认顺序变化导致前端课程列表跳动。
query.orderByDesc(ClassSubjectEntity::getDate)
.orderByDesc(ClassSubjectEntity::getId);
return Result.data(classSubjectService.list(query));
}
/** 判断当前用户的角色集合中是否包含指定角色。 */
private boolean hasRole(List<SysPhoneRoleEntity> roles, String roleName) {
return roles != null && roles.stream()
.anyMatch(role -> roleName.equals(role.getRoleName()));
}
} }
package com.platform.business.controller;
import com.baomidou.mybatisplus.core.MybatisConfiguration;
import com.baomidou.mybatisplus.core.conditions.Wrapper;
import com.baomidou.mybatisplus.core.conditions.query.LambdaQueryWrapper;
import com.baomidou.mybatisplus.core.metadata.TableInfoHelper;
import com.platform.business.model.entity.ClassSubjectEntity;
import com.platform.business.model.entity.SysPhoneRoleEntity;
import com.platform.business.model.entity.UserEntity;
import com.platform.business.service.AuthenticatedUserService;
import com.platform.business.service.ClassSubjectService;
import com.platform.business.service.SysPhoneRoleService;
import com.platform.exception.BusinessException;
import org.apache.ibatis.builder.MapperBuilderAssistant;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.ArgumentCaptor;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;
import org.springframework.mock.web.MockHttpServletRequest;
import org.springframework.test.util.ReflectionTestUtils;
import java.util.Arrays;
import java.util.Collections;
import static com.platform.business.constant.AccountAdminConstants.ROLE_ADMIN;
import static com.platform.business.constant.AccountAdminConstants.ROLE_STUDENT;
import static com.platform.business.constant.AccountAdminConstants.ROLE_TEACHER;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
/** 验证课程列表接口针对管理员、教师及无权限用户的数据范围。 */
@ExtendWith(MockitoExtension.class)
class ClassSubjectControllerTest {
@Mock
private ClassSubjectService classSubjectService;
@Mock
private AuthenticatedUserService authenticatedUserService;
@Mock
private SysPhoneRoleService sysPhoneRoleService;
private ClassSubjectController controller;
private MockHttpServletRequest request;
private UserEntity currentUser;
@BeforeAll
static void initializeMybatisPlusMetadata() {
// 单元测试不启动 Spring/MyBatis 容器,因此手动注册 Lambda 列解析所需的实体元数据。
TableInfoHelper.initTableInfo(
new MapperBuilderAssistant(new MybatisConfiguration(), ""),
ClassSubjectEntity.class);
}
@BeforeEach
void setUp() {
controller = new ClassSubjectController();
ReflectionTestUtils.setField(controller, "classSubjectService", classSubjectService);
ReflectionTestUtils.setField(controller, "authenticatedUserService", authenticatedUserService);
ReflectionTestUtils.setField(controller, "sysPhoneRoleService", sysPhoneRoleService);
request = new MockHttpServletRequest();
currentUser = new UserEntity();
currentUser.setId("teacher-1");
currentUser.setPhoneNumber("13800000000");
when(authenticatedUserService.current(request)).thenReturn(currentUser);
}
@Test
void administratorShouldQueryAllCoursesWithoutTeacherCondition() {
when(sysPhoneRoleService.queryByPhone(currentUser.getPhoneNumber()))
.thenReturn(Arrays.asList(role(ROLE_TEACHER), role(ROLE_ADMIN)));
when(classSubjectService.list(any(Wrapper.class))).thenReturn(Collections.emptyList());
controller.list(request);
LambdaQueryWrapper<ClassSubjectEntity> query = captureQuery();
// 同时具有教师和管理员角色时,管理员权限优先,查询条件中不应出现 teacher_id。
assertFalse(query.getSqlSegment().contains("teacher_id"));
}
@Test
void teacherShouldOnlyQueryCoursesAssignedToCurrentUser() {
when(sysPhoneRoleService.queryByPhone(currentUser.getPhoneNumber()))
.thenReturn(Collections.singletonList(role(ROLE_TEACHER)));
when(classSubjectService.list(any(Wrapper.class))).thenReturn(Collections.emptyList());
controller.list(request);
LambdaQueryWrapper<ClassSubjectEntity> query = captureQuery();
// MyBatis-Plus 将实际参数保存在参数映射中;这里同时校验列条件与可信的当前用户 ID。
assertTrue(query.getSqlSegment().contains("teacher_id"));
assertTrue(query.getParamNameValuePairs().containsValue(currentUser.getId()));
}
@Test
void nonTeacherAndNonAdministratorShouldBeRejected() {
when(sysPhoneRoleService.queryByPhone(currentUser.getPhoneNumber()))
.thenReturn(Collections.singletonList(role(ROLE_STUDENT)));
BusinessException exception = assertThrows(BusinessException.class,
() -> controller.list(request));
assertEquals("只有教师或管理员可以查询课程列表", exception.getMessage());
verify(classSubjectService, never()).list(any(Wrapper.class));
}
/** 捕获控制器交给 MyBatis-Plus 的查询条件,便于断言实际数据权限。 */
@SuppressWarnings("unchecked")
private LambdaQueryWrapper<ClassSubjectEntity> captureQuery() {
ArgumentCaptor<Wrapper<ClassSubjectEntity>> captor = ArgumentCaptor.forClass(Wrapper.class);
verify(classSubjectService).list(captor.capture());
return (LambdaQueryWrapper<ClassSubjectEntity>) captor.getValue();
}
/** 构造最小角色记录,避免测试依赖数据库。 */
private SysPhoneRoleEntity role(String roleName) {
SysPhoneRoleEntity role = new SysPhoneRoleEntity();
role.setRoleName(roleName);
return role;
}
}
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment